Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable SAML test #653

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Fix unstable SAML test #653

merged 1 commit into from
Jan 14, 2022

Conversation

KOliver94
Copy link
Contributor

@KOliver94 KOliver94 commented Jan 14, 2022

Proposed changes

After investing a lot of time into this issue, I realised it appears to happen only on Linux and not on Windows. I started to debug the methods and calls and it seemed to be an issue with XML parsing. The latest successful CI run used lxml version 4.6.4 and after version 4.7.1 it started to break. I did not inverstigate what could cause this seemingly platform dependent issue but there is also an open issue in python3-saml. I chose the easier path and pinned the version of lxml under 4.7.0 which seems to solve the issue.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #653 (5378daa) into master (1ea27e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   76.92%   76.92%           
=======================================
  Files         317      317           
  Lines        9630     9630           
  Branches      962      962           
=======================================
  Hits         7408     7408           
  Misses       2071     2071           
  Partials      151      151           
Flag Coverage Δ
unittests 76.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea27e8...5378daa. Read the comment docs.

@nijel
Copy link
Member

nijel commented Jan 14, 2022

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants