Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/python-social-auth/social-core/issues/918 #921

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Fleapse
Copy link
Contributor

@Fleapse Fleapse commented Jun 21, 2024

Make username always a string to avoid errors in the user pipeline.

Proposed changes

Bugfix #918

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Other information

I was unable to build the make tests docker image
everything ended in error
failed to solve: process "/bin/sh -c /pyenv.sh" did not complete successfully: exit code: 1

I’m not sure what this is connected with (perhaps due to the blocking of the docker hub in Russia or something else, but because of this I could not run the tests)

upd: dont know how, but after rerun docker compose run social-tests tests works

  py38: OK (47.50=setup[10.21]+cmd[2.90,34.39] seconds)
  py39: OK (44.02=setup[6.38]+cmd[3.03,34.61] seconds)
  py310: OK (42.92=setup[6.09]+cmd[2.95,33.88] seconds)
  py311: OK (44.56=setup[5.40]+cmd[4.35,34.81] seconds)
  py312: OK (48.56=setup[7.95]+cmd[4.62,35.99] seconds)
  congratulations :) (227.62 seconds)

Make username always a string to avoid errors in the user pipeline.
@nijel nijel linked an issue Jun 24, 2024 that may be closed by this pull request
@nijel nijel self-assigned this Jun 24, 2024
@nijel nijel merged commit 3449faf into python-social-auth:master Jun 24, 2024
7 checks passed
@nijel
Copy link
Member

nijel commented Jun 24, 2024

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TelegramAuth get_username get 'int' object is not subscriptable error
2 participants