Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of multi-line strings in YAML blocks #112

Merged
merged 1 commit into from May 10, 2020

Conversation

dato
Copy link
Contributor

@dato dato commented May 9, 2020

Closes #111.

To accept your contribution, please ensure that the checklist below is complete.

  • Is your name/identity in the AUTHORS file?
  • Does the code change (if the PR contains code) have 100% test coverage?
  • Is CI passing all quality and testing checks?

@codecov-io
Copy link

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          599       600    +1     
=========================================
+ Hits           599       600    +1     
Impacted Files Coverage Δ
tap/parser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015c21c...05c6b82. Read the comment docs.

Copy link
Member

@mblayman mblayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and finding this issue. The fix looks good to me. 👍

@mblayman mblayman merged commit 0aedb99 into python-tap:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional newlines added in YAML blocks for multi-line strings
3 participants