Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i18n support. #117

Merged
merged 1 commit into from Dec 29, 2021
Merged

Remove i18n support. #117

merged 1 commit into from Dec 29, 2021

Conversation

mblayman
Copy link
Member

The i18n support is from hand translated Google Translate results from years ago. I would be shocked if the translations are good at all. I don't have time to maintain the translations so I'm removing them for now.

To accept your contribution, please ensure that the checklist below is complete.

  • Is your name/identity in the AUTHORS file?
  • Does the code change (if the PR contains code) have 100% test coverage?
  • Is CI passing all quality and testing checks?

@codecov-commenter
Copy link

Codecov Report

Merging #117 (ecabb2a) into main (821b389) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   98.83%   99.15%   +0.31%     
==========================================
  Files          13       11       -2     
  Lines         602      590      -12     
==========================================
- Hits          595      585      -10     
+ Misses          7        5       -2     
Impacted Files Coverage Δ
tap/parser.py 100.00% <ø> (ø)
tap/runner.py 93.05% <ø> (-0.10%) ⬇️
tap/main.py 100.00% <100.00%> (ø)
tap/rules.py 100.00% <100.00%> (ø)
tap/tracker.py 100.00% <100.00%> (ø)
tap/__main__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821b389...ecabb2a. Read the comment docs.

@mblayman mblayman merged commit 07ebf38 into main Dec 29, 2021
@mblayman mblayman deleted the rm-i18n branch December 29, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants