_trigger_timeout() missing 1 required positional argument: 'job'

[loozhengyuan]

Steps to reproduce

1. Create a ConversationalHandler and use conversation_timeout=10
2. Launch the bot
3. Trigger command to enter conversation
4. Wait for 10sec
5. Error appears

Expected behaviour

The conversation should timeout

Actual behaviour

From the chat, nothing happens. If i respond normally after the supposed timeout should have taken place, the bot responds to me as if no timeout has taken place.

Configuration

Operating System:

ProductName:	Mac OS X
ProductVersion:	10.14.3
BuildVersion:	18D109

Version of Python, python-telegram-bot & dependencies:

python-telegram-bot 12.0.0b1
certifi 2019.03.09
future 0.17.1
Python 3.7.2 (default, Feb 12 2019, 08:15:36)  [Clang 10.0.0 (clang-1000.11.45.5)]

Logs

2019-03-18 10:33:52,327 - JobQueue - DEBUG - Ticking jobs with t=1552876432.327480
2019-03-18 10:33:52,329 - JobQueue - DEBUG - Peeked at _trigger_timeout with t=1552876432.325519
2019-03-18 10:33:52,331 - JobQueue - DEBUG - Running job _trigger_timeout
2019-03-18 10:33:52,332 - JobQueue - ERROR - An uncaught error was raised while executing job _trigger_timeout
Traceback (most recent call last):
  File "/venv/lib/python3.7/site-packages/telegram/ext/jobqueue.py", line 260, in tick
    job.run(self._dispatcher)
  File "/venv/lib/python3.7/site-packages/telegram/ext/jobqueue.py", line 388, in run
    self.callback(CallbackContext.from_job(self, dispatcher))
TypeError: _trigger_timeout() missing 1 required positional argument: 'job'
2019-03-18 10:33:52,338 - JobQueue - DEBUG - Dropping non-repeating or removed job _trigger_timeout

[jsmnbom]

It looks like we missed the _trigger_timeout callback when we went through the codebase updating to context based handlers. Thanks for the report, we'll get it fixed when we can :)

[felixlinker]

I'm getting the same exception in version 12.0.0b1:

2019-07-22 01:51:36,073 - JobQueue - ERROR - An uncaught error was raised while executing job _trigger_timeout
Traceback (most recent call last):
  File "C:\Users\felix\.virtualenvs\telegram-plakat-bot-C1d6WWSe\lib\site-packages\telegram\ext\jobqueue.py", line 260, in tick
    job.run(self._dispatcher)
  File "C:\Users\felix\.virtualenvs\telegram-plakat-bot-C1d6WWSe\lib\site-packages\telegram\ext\jobqueue.py", line 388, in run
    self.callback(CallbackContext.from_job(self, dispatcher))
TypeError: _trigger_timeout() missing 1 required positional argument: 'job'

This is how my conversation handler looks:

from telegram.ext import CommandHandler, MessageHandler, ConversationHandler, Filters


ANY = range(1)


def start(update, context):
    return ANY


def any(update, context):
    pass


def cancel(update, context):
    return ConversationHandler.END


def no_parse(update, context):
    pass


def conversation_handler():
    return ConversationHandler(
        entry_points=[CommandHandler('tot', start)],
        states={
            ANY: [MessageHandler(
                ~Filters.command,
                any
            )]
        },
        fallbacks=[
            CommandHandler('cancel', cancel),
            MessageHandler(Filters.update, no_parse)
        ],
        conversation_timeout=10
    )

[loozhengyuan]

Hello @felixlinker, i think this issue is still existent on the latest beta release which I first encountered it. Until the release is bumped, you can install the master branch so the latest changes are reflected.