Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Py3.8+ features: CancelledError is a subclass of BaseException #3731

Closed
Tracked by #3728
Bibo-Joshi opened this issue Jun 2, 2023 · 0 comments · Fixed by #3754
Closed
Tracked by #3728

Adopt Py3.8+ features: CancelledError is a subclass of BaseException #3731

Bibo-Joshi opened this issue Jun 2, 2023 · 0 comments · Fixed by #3754
Assignees

Comments

@Bibo-Joshi
Copy link
Member

Python 3.8 makes asyncio.CancelledError as subclass of BaseException. As a consequence, it is no longer catched by except Exception clauses and we no longer need special casing in the style of except asyncio.CancelledError.
We review our code base for explicit usages of asyncio.CancelledError and check which ones of them we can drop.

A PR in this direction is very welcome. As long as #3728 is open, it should be based on the drop-py-37 branch. If you would like to send a PR, please be sure to read our contribution guide and leave a short comment so that we can assign you.

@clot27 clot27 self-assigned this Jun 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants