Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CancelledError #3754

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Drop CancelledError #3754

merged 2 commits into from
Jun 17, 2023

Conversation

clot27
Copy link
Member

@clot27 clot27 commented Jun 13, 2023

closes #3731
Used grep to find all usescases of CancelledError

@Bibo-Joshi Bibo-Joshi changed the base branch from master to drop-py-37 June 13, 2023 20:13
@Bibo-Joshi
Copy link
Member

Before merging, I'd like to have it double checked that unit tests exit for all the cases were CancelledError was used so far

@Bibo-Joshi Bibo-Joshi merged commit cf71a38 into drop-py-37 Jun 17, 2023
18 checks passed
@Bibo-Joshi Bibo-Joshi deleted the drop-cancellederror branch June 17, 2023 07:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt Py3.8+ features: CancelledError is a subclass of BaseException
2 participants
@clot27 @Bibo-Joshi