New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] API 7.0 #4033
Comments
Hi! I'd love to work on reactions. |
Hey! Thanks for your intent! Unfortunately, the reactions part has already been taken by @Poolitzer as is indicated beside the bullet point. You may choose any other bullet points which haven't been taken yet |
Okay. Then Block quotation.
|
@clot27 A tew thoughts after reading the changelog: • I guess we'll keep |
Some insights for the
|
More thoughts on
Independently of that, @harshil proposed a helper function for the
Initially I thought that computing the entities would be tricky, but I guess with Building up on Harshils idea, I had the thought that one could extend this method to something like If we have such a method, this might also give other options to handle the
For interenal reference, let me link to a message in the dev chat about defaults handling: https://t.me/c/1494805131/39152 In summary, integrating the update into the existing PTB convenience functionality is unfortunately not straight forward. I would appreciate feedback from the dev team on my write-up. |
Agreed
Into
I like this way more then the other ideas Not allowing formatted strings, users might think there is only one occurrence of the text but there are several, just differentiated by formatting. So I would definitely also allow formatted strings. I like the index part. not sure I see the upside of build_reply_arguments instead of simply passing them |
No, I rather had an additional argument for
That's exactly my example though: "<i>ABC</i> ABC" contains the string "ABC" twice. The firts occurence is unformatted, the second one is formatted in italic. If the user now passes
Sorry I don't understand. What do you mean by "simply passing them"? |
... but that is already there, as
Ohhhh double the markdown, twice the fall. Yeah I see that. Okay I think non formatted text it is then, hope that doesn't confuse users too much...
I get the feeling you are trying to solve a problem I am not seeing as one yet. What is the improvement for a user to have the builder instead of initiating the class like any other? Btw I gave the "how do we avoid the double passing of message_id" some thought, and I think the best way is to make a class without the parameter, which can only be used in the shortcuts (so we raise if someone uses it in a non shortcut) and in the shortcuts we change it to the actual class. |
No,
👍
User has set Defaults.allow_sending_without_reply = True
This would be my 3rd bullet point in #4033 (comment). the problem that I see with this approach is that it can cause a lot of confusion about which class to use where. Moreover, it's unclear to me where we could cleanly place such a class within the |
Provided a PoC implementation draft in #4058 |
This comment was marked as off-topic.
This comment was marked as off-topic.
hi, please make a separate issue for that, don't comment in the one for API 7.0 changes |
What kind of feature are you missing? Where do you notice a shortcoming of PTB?
This is the biggest bot API update ever!, hence opening this issue to keep the track of all changes.
Important
api-7.0
branchDescribe the solution you'd like
Reactions
Replies 2.0
Link Preview Customization - @harshil21
Block Quotation
Message.text_(html|markdown(_v2)?)
- seeblockquote
message entity api-7.0. #4038 (comment) and Blockquote api 7.0 branched #4061Multiple Message Actions @clot27
Request for multiple users @Bibo-Joshi
Chat Boost - @harshil21
Giveaway @Bibo-Joshi
Web App Changes- [ ] Added the field SettingsButton to the class WebApp.- [ ] Added the fields header_bg_color, accent_text_color, section_bg_color, section_header_text_color, subtitle_text_color, destructive_text_color to the class ThemeParams.Other Changes
Describe alternatives you've considered
If you want to contribute, you can start from the Contribution Guide.
Additional context
Please comment below before start working on any part of the update so as to keep things in track and avoid double work.
The text was updated successfully, but these errors were encountered: