-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v3.6 API #1006
Support v3.6 API #1006
Conversation
For Now I renamed the PR, since it already contains two of the newly added features. Will look in depth later. |
I think the |
Yeah, I just saw that parse_mode also affects |
…egram.InputMediaVideo Fixed Docstrings for parse_mode in captions
Ok, I finished up and made some adjustments. |
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
========================================
Coverage ? 91.8%
========================================
Files ? 103
Lines ? 4136
Branches ? 669
========================================
Hits ? 3797
Misses ? 197
Partials ? 142
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work on this @code1mountain and @Eldinnie.
After a fairly quick lookover I couldn't find any errors or anything like that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eldinnie @code1mountain
In general, LGTM.
However, there are three places where the new function arguments needs to be moved to the end of the function prototype in order to maintain backward compatibility:
- send_photo
- send_audio
- edit_message_caption
changing that and we're good to go
Also needs to be fixed on |
@code1mountain |
@tsnoam Yes, because I did too |
my bad, i tried to push to the wrong branch. |
@code1mountain thanks for your contribution! |
Added support for connected_website from Bot API v3.6.
Update: Also added support for parse_modes in captions. I added only tests for parse_mode in captions in tests/test_photo.py, because adding a test for all kind of messages that contain a caption is redundant.
Update 2: I added the support for the parse_mode parameter in all InlineQueryResults
Update 3: Added the support streaming parameter to telegram.Bot.send_video and InputMediaVideo. The streaming parameter will not work for any videos you send by file_id, that don't support streaming already or sending by file or url for files, the telegram server already downloaded once. Anyways, Telegram won't raise an Error for that.
Fixes part 1 + 3 + 4 from issue #1005