New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #1012

Merged
merged 3 commits into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@tsnoam
Member

tsnoam commented Feb 19, 2018

closes #795 and other deprecated stuff

@tsnoam tsnoam requested a review from Eldinnie Feb 19, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Feb 19, 2018

Codecov Report

Merging #1012 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   91.86%   92.08%   +0.22%     
==========================================
  Files         103      103              
  Lines        4177     4155      -22     
  Branches      671      667       -4     
==========================================
- Hits         3837     3826      -11     
+ Misses        197      192       -5     
+ Partials      143      137       -6
Impacted Files Coverage Δ
telegram/ext/updater.py 78.33% <ø> (+1.15%) ⬆️
telegram/bot.py 88.17% <ø> (+0.32%) ⬆️
telegram/message.py 97.06% <ø> (+0.64%) ⬆️
telegram/ext/filters.py 99.13% <ø> (ø) ⬆️
telegram/ext/jobqueue.py 92.85% <100%> (+0.75%) ⬆️
telegram/utils/request.py 68.75% <0%> (+0.89%) ⬆️

codecov bot commented Feb 19, 2018

Codecov Report

Merging #1012 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   91.86%   92.08%   +0.22%     
==========================================
  Files         103      103              
  Lines        4177     4155      -22     
  Branches      671      667       -4     
==========================================
- Hits         3837     3826      -11     
+ Misses        197      192       -5     
+ Partials      143      137       -6
Impacted Files Coverage Δ
telegram/ext/updater.py 78.33% <ø> (+1.15%) ⬆️
telegram/bot.py 88.17% <ø> (+0.32%) ⬆️
telegram/message.py 97.06% <ø> (+0.64%) ⬆️
telegram/ext/filters.py 99.13% <ø> (ø) ⬆️
telegram/ext/jobqueue.py 92.85% <100%> (+0.75%) ⬆️
telegram/utils/request.py 68.75% <0%> (+0.89%) ⬆️
@Eldinnie

Looks good to me

@tsnoam tsnoam merged commit 3762792 into master Feb 22, 2018

5 checks passed

codeclimate 1 fixed issue
Details
codecov/patch 100% of diff hit (target 91.86%)
Details
codecov/project 92.08% (+0.22%) compared to baec1bb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tsnoam tsnoam deleted the remove_deprecated branch Feb 22, 2018

FiveBoroughs referenced this pull request in Whalepool/Natalia Aug 3, 2018

fix for new chat member greetings
how it was: some chat member invite new member and bot greets the person who did invite, but not who was invited

Now the bot greets always the newcomer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment