Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #1012

Merged
merged 3 commits into from
Feb 22, 2018
Merged

Remove deprecated code #1012

merged 3 commits into from
Feb 22, 2018

Conversation

tsnoam
Copy link
Member

@tsnoam tsnoam commented Feb 19, 2018

closes #795 and other deprecated stuff

@tsnoam tsnoam requested a review from Eldinnie February 19, 2018 12:17
@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #1012 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   91.86%   92.08%   +0.22%     
==========================================
  Files         103      103              
  Lines        4177     4155      -22     
  Branches      671      667       -4     
==========================================
- Hits         3837     3826      -11     
+ Misses        197      192       -5     
+ Partials      143      137       -6
Impacted Files Coverage Δ
telegram/ext/updater.py 78.33% <ø> (+1.15%) ⬆️
telegram/bot.py 88.17% <ø> (+0.32%) ⬆️
telegram/message.py 97.06% <ø> (+0.64%) ⬆️
telegram/ext/filters.py 99.13% <ø> (ø) ⬆️
telegram/ext/jobqueue.py 92.85% <100%> (+0.75%) ⬆️
telegram/utils/request.py 68.75% <0%> (+0.89%) ⬆️

Copy link
Member

@Eldinnie Eldinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tsnoam tsnoam merged commit 3762792 into master Feb 22, 2018
@tsnoam tsnoam deleted the remove_deprecated branch February 22, 2018 12:17
FiveBoroughs referenced this pull request in Whalepool/Natalia Aug 3, 2018
how it was: some chat member invite new member and bot greets the person who did invite, but not who was invited

Now the bot greets always the newcomer
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated Message.new_chat_member
2 participants