Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Tools for deep linking #1049

Merged
merged 7 commits into from Sep 13, 2019

Conversation

@JosXa
Copy link
Contributor

JosXa commented Mar 16, 2018

Allows
url = helpers.create_deep_linked_url(bot.get_me().username, "Payload")

JosXa added 2 commits Mar 16, 2018
@jh0ker

This comment has been minimized.

Copy link
Member

jh0ker commented Mar 16, 2018

Looks good, but the example seems very convoluted. Do we really need 3 levels of deep linking to demonstrate how a single function works?

@JosXa

This comment has been minimized.

Copy link
Contributor Author

JosXa commented Mar 16, 2018

@jh0ker It's more about explaining what's possible with deep links and to spark the imagination a bit

@jh0ker

This comment has been minimized.

Copy link
Member

jh0ker commented Mar 16, 2018

Fair enough, but in that case perhaps you could make one of the levels use an inline button with a URL instead of just another text link

@JosXa

This comment has been minimized.

Copy link
Contributor Author

JosXa commented Mar 16, 2018

Good point

Copy link
Member

jsmnbom left a comment

Seems like a nice utility to have to me :D
I added a few comments though :)

telegram/utils/helpers.py Outdated Show resolved Hide resolved
telegram/utils/helpers.py Outdated Show resolved Hide resolved
examples/deeplinking.py Show resolved Hide resolved
@tsnoam

This comment has been minimized.

Copy link
Member

tsnoam commented May 7, 2018

@JosXa
What is the status of this PR? ( @bomjacob requested certain changes)

@JosXa

This comment has been minimized.

Copy link
Contributor Author

JosXa commented Oct 30, 2018

Currently not having the time to fix it up. Anyone else interested in getting the kudos for this contribution? @bomjacob

@Bibo-Joshi

This comment has been minimized.

Copy link
Member

Bibo-Joshi commented Sep 6, 2019

Brought this PR up to date and implemented the requested changes.
Also made it possible create startgroup deep linking urls using @JosXa s new helpers method

@tsnoam tsnoam merged commit ccf5e6c into master Sep 13, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 92.86%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +7.13% compared to d5399de
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tsnoam tsnoam deleted the deeplinking-tools branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.