Implemented Tools for deep linking #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but the example seems very convoluted. Do we really need 3 levels of deep linking to demonstrate how a single function works? |
|
@jh0ker It's more about explaining what's possible with deep links and to spark the imagination a bit |
|
Fair enough, but in that case perhaps you could make one of the levels use an inline button with a URL instead of just another text link |
|
Good point |
jsmnbom
requested changes
Mar 22, 2018
|
Currently not having the time to fix it up. Anyone else interested in getting the kudos for this contribution? @bomjacob |
|
Brought this PR up to date and implemented the requested changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
url = helpers.create_deep_linked_url(bot.get_me().username, "Payload")