Make chat_id a positional argument inside shortcut methods of Chat and User classes #1048

[xates]

No description provided.

[jh0ker]

Looks good to me, no problems with backwards compatibility I can see. Should be good to merge

[jh0ker]

@xates Looks like you also have to update the tests

[xates]

Ok, I have tried to figure out how they work but I am not entirely sure... would something like that work for test_chat.py for example?

    def test_instance_method_send_message(self, monkeypatch, chat):
        def test(*args, **kwargs):
            return args[0] == chat.id and args[1] == 'test'

        monkeypatch.setattr('telegram.Bot.send_message', test)
        assert chat.send_message('test')

    def test_instance_method_send_audio(self, monkeypatch, chat):
        def test(*args, **kwargs):
            return args[0] == chat.id and args[1] == 'test_audio'

        monkeypatch.setattr('telegram.Bot.send_audio', test)
        assert chat.send_audio('test_audio')

Moreover, I have noticed that both Chat and User classes lack the tests for send_photo. Is that intentional or should I add them?

[jh0ker]

I believe that will work, but please confirm it locally before committing (as per contributing guide).

And yes, that looks like an oversight, adding tests for send_photo would be appreciated 👍

[xates]

I cannot run the tests locally because I get an ImportError: No module named ptb_urllib3.urllib3

[Eldinnie]

@xates Looks like you didn't follow this step from the contributing guide:

Clone your forked repository of python-telegram-bot to your computer:

$ git clone https://github.com/<your username>/python-telegram-bot --recursive

To fix it run:

$ git submodule update --init --recursive

[jh0ker]

@xates Sounds like you didn't clone with --recursive to also clone git submodules (as per contribution guide)
beat me to it

[xates]

You're right, sorry, I missed that --recursive that was at the end

[jh0ker]

If you got errors in test_get_chat you can ignore them

[xates]

Oh, I see! That was driving me crazy...

[jh0ker]

I'm sorry about that, someone unwittingly renamed the group that is used in that test so the test suddenly failed everywhere.

[jh0ker]

Looks good to me 👍

[jh0ker]

Thank you very much for your contribution :)

[xates]

Yeah, I guess that SSL problem is not my fault 😄

Well, thank you, for running such a wonderful project 😉

[jh0ker]

Eh, tests sometimes pass and fail depending on the alignment of the planets 🌑