New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly make Bot.full_name return a unicode object, rather than implicitly a unicode object in Python 3 and a str object on Python 2. #1063

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
3 participants
@nmlorg
Contributor

nmlorg commented Apr 2, 2018

Fixes #1043.

Explicitly make Bot.full_name return a unicode object, rather than im…
…plicitly a unicode object in Python 3 and a str object on Python 2.
@tsnoam

tsnoam approved these changes Apr 16, 2018

LGTM. Waiting for appveyor tests to succeed.

@jh0ker jh0ker merged commit cbfb7df into python-telegram-bot:master Apr 16, 2018

5 checks passed

codecov/patch 100% of diff hit (target 92.58%)
Details
codecov/project Absolute coverage decreased by -0.08% but relative coverage increased by +7.41% compared to 3ccf40e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
@jh0ker

This comment has been minimized.

Show comment
Hide comment
@jh0ker

jh0ker Apr 16, 2018

Member

Thank you for your contribution!

Member

jh0ker commented Apr 16, 2018

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment