Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly make Bot.full_name return a unicode object, rather than implicitly a unicode object in Python 3 and a str object on Python 2. #1063

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Explicitly make Bot.full_name return a unicode object, rather than implicitly a unicode object in Python 3 and a str object on Python 2. #1063

merged 1 commit into from
Apr 16, 2018

Conversation

nmlorg
Copy link
Contributor

@nmlorg nmlorg commented Apr 2, 2018 •
edited
Loading

Fixes #1043.

@nmlorg
Explicitly make Bot.full_name return a unicode object, rather than im…
ce9aabc 
…plicitly a unicode object in Python 3 and a str object on Python 2.
tsnoam
tsnoam approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for appveyor tests to succeed.

@jh0ker jh0ker merged commit cbfb7df into python-telegram-bot:master Apr 16, 2018
@jh0ker
Copy link
Member

jh0ker commented Apr 16, 2018

Thank you for your contribution!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User.full_name doesn't handle non-ASCII (in Python 2?)
3 participants
@nmlorg @jh0ker @tsnoam