Add a caption_entity filter for filtering caption entities #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'd also be nice to have one filter for both entity types, but having trouble naming it; all_entity, any_entity, either_entity, both_entity all seem kinda misleading. |
|
This would be really helpful. Code looks good aswell. +1 |
jh0ker
reviewed
Apr 18, 2018
telegram/ext/filters.py
Outdated
| self.name = 'Filters.caption_entity({})'.format(self.entity_type) | ||
|
|
||
| def filter(self, message): | ||
| return any([entity.type == self.entity_type for entity in message.caption_entities]) |
There was a problem hiding this comment.
nitpick, but why not just use a generator expression instead of a list comprehension?
There was a problem hiding this comment.
totally agree, i copy pasted the previous filter code is why
jh0ker
approved these changes
Apr 20, 2018
| @@ -532,7 +532,28 @@ def __init__(self, entity_type): | |||
| self.name = 'Filters.entity({})'.format(self.entity_type) | |||
|
|
|||
| def filter(self, message): | |||
| return any([entity.type == self.entity_type for entity in message.entities]) | |||
| return any(entity.type == self.entity_type for entity in message.entities) | |||
|
Thanks for your contribution 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Filters.entity filter only checks message.entities.
This PR adds Filters.caption_entities to check message.caption_entities.