Handle utf8 decoding errors #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmlorg
reviewed
Apr 16, 2018
telegram/utils/request.py
Outdated
| data = json.loads(decoded_s) | ||
| except UnicodeDecodeError: | ||
| logging.getLogger(__name__).debug( | ||
| 'Logging raw invalid UTF-8 response:\n%s', str(json_data)) |
There was a problem hiding this comment.
In Python 2 str is the byte array type, so str(json_data) is a noop (the bogus UTF-8 will enter the logging stream). I didn't realize str(b'...') was the same as repr(b'...') in Python 3 until I just tried it, is that what you were intending? What about just ('Logging raw invalid UTF-8 response:\n%r', json_data)?
tsnoam
approved these changes
Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #1072, malicious clients can send arbitrary
callback_datain callback queries, even bytes that can't be decoded using the utf-8 codec. This would bring the whole bot to a halt.