Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputFile: Fix proper naming of file when reading from subprocess.PIPE #1079

Merged
merged 5 commits into from
May 2, 2018
Merged

InputFile: Fix proper naming of file when reading from subprocess.PIPE #1079

merged 5 commits into from
May 2, 2018

Conversation

tsnoam
Copy link
Member

@tsnoam tsnoam commented Apr 21, 2018

fixes #1055

@jsmnbom
Copy link
Member

jsmnbom commented Apr 30, 2018

This looks good, except on windows you'd want the the png path to use \ instead of / in the test.

@tsnoam tsnoam merged commit 0a8abcc into master May 2, 2018
@tsnoam tsnoam deleted the inputfile_pipe branch May 2, 2018 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow subprocess.Popen.stdout as file input
2 participants
@tsnoam @jsmnbom