Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add urllib3 fix for socks5h support #1085

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
2 participants
@tsnoam
Copy link
Member

tsnoam commented Apr 25, 2018

FIxes #1077
Changes semantics of socks proxy behaviour.
Until now - socks5:// was actually socs5h:// and we didn't really have socks5://

@jh0ker

jh0ker approved these changes Apr 25, 2018

Copy link
Member

jh0ker left a comment

LGTM

@tsnoam tsnoam merged commit 1ec1234 into master Apr 25, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!

@tsnoam tsnoam deleted the urllib3_socks5h branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.