Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProcessLookupError if process finishes before we kill it #1126

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Fix ProcessLookupError if process finishes before we kill it #1126

merged 1 commit into from
Jun 1, 2018

Conversation

socram8888
Copy link
Contributor

Fix for #1125

tsnoam
tsnoam approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I restarted the unitests, though it doesn't look like the failures are related to this change.

Also, you may add yourself to AUTHORS.rst if you'd like.

@tsnoam tsnoam merged commit d2059ed into python-telegram-bot:master Jun 1, 2018
@tsnoam
Copy link
Member

tsnoam commented Jun 1, 2018

@socram8888
Thank you for your contribution.

@socram8888
Copy link
Contributor Author

You're welcome.

I'll look into the other PR as soon as I get some more free time.

@socram8888 socram8888 deleted the proclookuperr branch June 1, 2018 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@socram8888 @tsnoam