New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProcessLookupError if process finishes before we kill it #1126

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@socram8888
Contributor

socram8888 commented May 29, 2018

Fix for #1125

@tsnoam

tsnoam approved these changes May 29, 2018

LGTM
I restarted the unitests, though it doesn't look like the failures are related to this change.

Also, you may add yourself to AUTHORS.rst if you'd like.

@tsnoam tsnoam merged commit d2059ed into python-telegram-bot:master Jun 1, 2018

5 checks passed

Hound No violations found. Woof!
codecov/patch Coverage not affected when comparing 42daf96...fab96ac
Details
codecov/project 93.01% (+0.5%) compared to 42daf96
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tsnoam

This comment has been minimized.

Show comment
Hide comment
@tsnoam

tsnoam Jun 1, 2018

Member

@socram8888
Thank you for your contribution.

Member

tsnoam commented Jun 1, 2018

@socram8888
Thank you for your contribution.

@socram8888

This comment has been minimized.

Show comment
Hide comment
@socram8888

socram8888 Jun 1, 2018

Contributor

You're welcome.

I'll look into the other PR as soon as I get some more free time.

Contributor

socram8888 commented Jun 1, 2018

You're welcome.

I'll look into the other PR as soon as I get some more free time.

@socram8888 socram8888 deleted the socram8888:proclookuperr branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment