Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use '==' operator for integer comparison #1147

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Conversation

jh0ker
Copy link
Member

@jh0ker jh0ker commented Jun 30, 2018

No description provided.

@jh0ker jh0ker requested a review from JosXa June 30, 2018 19:18
Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though the other should technically work, this is definitely more correct :)

@jsmnbom jsmnbom merged commit 3534102 into master Aug 26, 2018
@jsmnbom jsmnbom deleted the fix-bad-integer-comparison branch September 1, 2018 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants