New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use '==' operator for integer comparison #1147

Merged
merged 1 commit into from Aug 26, 2018

Conversation

Projects
None yet
2 participants
@jh0ker
Member

jh0ker commented Jun 30, 2018

No description provided.

@jh0ker jh0ker added the bug 🐛 label Jun 30, 2018

@jh0ker jh0ker requested a review from JosXa Jun 30, 2018

@jsmnbom

jsmnbom approved these changes Jul 8, 2018

LGTM

Though the other should technically work, this is definitely more correct :)

@jsmnbom jsmnbom merged commit 3534102 into master Aug 26, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!

@jsmnbom jsmnbom deleted the fix-bad-integer-comparison branch Sep 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment