Add Conflict error (HTTP error code 409) #1154
Conversation
|
hmm, Not to be blunt but why should we patch a user_error? I think the case in #1143 is too specific to add this feature.. |
|
The way I see it, is that telegram is returning a custom http error code, which we should handle on par with how we handle other 4xx error codes. Adding the conflicting id is just a quality of life type of improvement in my opinion. Doesn't really harm anything, but will probably make it easier to debug issues for some people. |
telegram/error.py
Outdated
|
|
||
| class Conflict(TelegramError): | ||
| def __init__(self, msg, url): | ||
| match = re.search(r'bot(\d+):.*/', url) |
There was a problem hiding this comment.
Can you please add a comment on the code itself what is the input string and why it means a conflicting bot id? (in favour of future us who won't remember all the details...)
|
What's the status on this? We discussed it a few times. I seem to remember we decided not to add this except for the exception? |
Yes, exactly. @jsmnbom was on it. I thought it was already merged. |
|
Yes, I'm on it, will update the PR tomorrow when I have time :) |
jsmnbom
changed the title
jsmnbom
dismissed
tsnoam’s stale review
Outdated + discussed in internal chat.
Fixes #1143.
Do we need tests for stuff like this?