Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text mention for message parse #1206

Merged

Conversation

@ehsanonline
Copy link
Contributor

ehsanonline commented Sep 4, 2018

Now we can get the mentioned user in text's that are parsed with HTML or Markdown formatting.

ehsanonline added 2 commits Sep 4, 2018
Copy link
Member

jsmnbom left a comment

Looks good to me! Only a small comment about the gitignore :)

.gitignore Outdated
@@ -63,6 +63,9 @@ target/
# Sublime Text 2
*.sublime*

# Visual Studio Code

This comment has been minimized.

Copy link
@jsmnbom

jsmnbom Sep 10, 2018

Member

Could you remove this from the PR since it isn't really relavant?

Hint: you can add this rule in your local .gitignore

This comment has been minimized.

Copy link
@ehsanonline

ehsanonline Sep 12, 2018

Author Contributor

Sure.

isjerryxiao referenced this pull request in isjerryxiao/AntiSpamBot Sep 13, 2018
Copy link
Member

jsmnbom left a comment

Thanks a lot for at update.
Congratulations on your first contribution @ehsanonline!

@jsmnbom jsmnbom merged commit 3829666 into python-telegram-bot:master Sep 25, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.