Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text mention for message parse #1206

Merged

Conversation

ehsanonline
Copy link
Contributor

Now we can get the mentioned user in text's that are parsed with HTML or Markdown formatting.

Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only a small comment about the gitignore :)

.gitignore Outdated
@@ -63,6 +63,9 @@ target/
# Sublime Text 2
*.sublime*

# Visual Studio Code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this from the PR since it isn't really relavant?

Hint: you can add this rule in your local .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

isjerryxiao referenced this pull request in isjerryxiao/AntiSpamBot Sep 13, 2018
Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for at update.
Congratulations on your first contribution @ehsanonline!

@jsmnbom jsmnbom merged commit 3829666 into python-telegram-bot:master Sep 25, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants