Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix unresolvable promises #1270
Good catch, thanks for your contribution!
This also seems to be the behavior for when a synchronous entry point handler returns
It would also be great if you could add a unit test that tests for this bug, so we won't have any regressions in the future. It should probably look similar to this test.
Edit: I don't think the caveat you mentioned is real, pretty sure it is already not possible to use
Thanks a lot :D
So a note in the ConversationHandler class docstring about this behaviour (both sync and async) sounds good yea :)