Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add break to for loops to avoid multiple repetitive warnings on conve… #1319

Conversation

@Ambro17
Copy link
Contributor

Ambro17 commented Jan 3, 2019

As spoken earlier today with @Eldinnie, it seems fair to show the warnings explaining the edge cases for the conversation handlers. But if one has a complex conversation, those messages are replied too many times and don't give new information.

This PR makes those warnings appear only once and add tests for this behaviour.

@jsmnbom jsmnbom requested a review from Eldinnie Jan 4, 2019
@Eldinnie

This comment has been minimized.

Copy link
Member

Eldinnie commented Feb 13, 2019

Looks good to me.

@Eldinnie Eldinnie merged commit d0936f7 into python-telegram-bot:master Feb 13, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.