Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1328: custom timeout argument does not work #1330

Merged
merged 2 commits into from Jan 30, 2019

Conversation

@lorien
Copy link
Contributor

lorien commented Jan 23, 2019

No description provided.

lorien added 2 commits Jan 23, 2019
@jsmnbom

This comment has been minimized.

Copy link
Member

jsmnbom commented Jan 30, 2019

Thanks a lot for catching this :D
After testing locally it looks like we can ignore the CI errors (telegram changed some internal stuff once again sigh)
It also looks like this might actually fix #1323. I'll ask in the thread if others agree.
The changed test looks alright too, so I'm gonna go ahead and merge this as-is :) Good job :D

@jsmnbom jsmnbom merged commit 3e8d715 into python-telegram-bot:master Jan 30, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
lvps added a commit to WEEE-Open/WEEEtofono that referenced this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.