Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #1348

Merged
merged 12 commits into from
Feb 18, 2019
Merged

Documentation fixes #1348

merged 12 commits into from
Feb 18, 2019

Conversation

jsmnbom
Copy link
Member

@jsmnbom jsmnbom commented Feb 17, 2019

  • Clarify InlineKeyboardButton callback-data docstring
  • Prettier changelog
  • Link to examples on frontpage
  • Link to wiki on frontpage
  • Put telegram.ext in own sidebar thing
  • Remove :obj:Filter as it's pretty obvious that it's a filter since it's in this module. It also made the html output about 1/3 times longer to scroll through.
  • Add an __all__ to reorder so Filter is at the top instead of BaseFilter
  • Add a proper docstring for document that documents the attributes (superseeds Improve documentation of 'telegram.ext.filters' module #1089)
  • Also fix a couple of grammar errors.

- Prettier changelog
- Link to examples on frontpage
- Link to wiki on frontpage
- Put telegram.ext in own sidebar thingy
Superseeds #1089

- Remove `:obj:Filter` as it's pretty obvious that it's a filter since it's in this module. It also made the html output about 1/3 times longer to scroll through.
- Add an __all__ to reorder so Filter is at the top instead of BaseFilter
- Add a proper docstring for document that documents the attributes (this is the #1089 part)
- Also fix a couple of grammar errors.
@jsmnbom jsmnbom marked this pull request as ready for review February 17, 2019 20:32
Copy link
Member

@Eldinnie Eldinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really good. Some small questions and proposed changes

docs/source/telegram.rst Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
Eldinnie and others added 5 commits February 17, 2019 23:50
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
so we don't have more issues with incongruent versions
@jsmnbom jsmnbom merged commit 26ce9bb into master Feb 18, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants