Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #1348

Merged
merged 12 commits into from Feb 18, 2019

Conversation

@jsmnbom
Copy link
Member

jsmnbom commented Feb 17, 2019

  • Clarify InlineKeyboardButton callback-data docstring
  • Prettier changelog
  • Link to examples on frontpage
  • Link to wiki on frontpage
  • Put telegram.ext in own sidebar thing
  • Remove :obj:Filter as it's pretty obvious that it's a filter since it's in this module. It also made the html output about 1/3 times longer to scroll through.
  • Add an __all__ to reorder so Filter is at the top instead of BaseFilter
  • Add a proper docstring for document that documents the attributes (superseeds #1089)
  • Also fix a couple of grammar errors.
jsmnbom added 3 commits Feb 17, 2019
- Prettier changelog
- Link to examples on frontpage
- Link to wiki on frontpage
- Put telegram.ext in own sidebar thingy
Superseeds #1089

- Remove `:obj:Filter` as it's pretty obvious that it's a filter since it's in this module. It also made the html output about 1/3 times longer to scroll through.
- Add an __all__ to reorder so Filter is at the top instead of BaseFilter
- Add a proper docstring for document that documents the attributes (this is the #1089 part)
- Also fix a couple of grammar errors.
@jsmnbom jsmnbom marked this pull request as ready for review Feb 17, 2019
Copy link
Member

Eldinnie left a comment

Overall really good. Some small questions and proposed changes

docs/source/telegram.rst Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
Eldinnie and others added 5 commits Feb 17, 2019
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
so we don't have more issues with incongruent versions
@jsmnbom jsmnbom merged commit 26ce9bb into master Feb 18, 2019
1 of 3 checks passed
1 of 3 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.