Making merged filters short-circuit #1350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the behaviour back pre-datafilters.
Reasons:
and
andor
, and those keywords do short circuit.Filters.reply & some_filter_that_assumes_reply_to_message_exists
without needing to check explicitly ifreply_to_message
exsists insome_filter_that_assumes_reply_to_message_exists
. Note that an explicit check (or try except ofc) cause otherwise the check will crash the thread if it is not a reply.