-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 4.4 changes #1464
Merged
Merged
API 4.4 changes #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI: The 4.2 and 4.3 Changes are still not merged: #1418 |
Pls remove the |
Ah, overlooked that one. Thanks for the heads up :) |
Conflicts: telegram/chatmember.py tests/test_bot.py
Closed
Eldinnie
requested changes
Sep 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes
tsnoam
approved these changes
Sep 6, 2019
This reverts commit c4538e5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to incorporate API 4.4 changes.
Stuff I'm not sure I handled it correctly:
de_json
methods (Chat
andChatPermission
)all_members_are_administrators
inChat
restrict_chat_members
inBot
MessageEntities
: I adjustedMessage._parse_html
andMessage._parse_markdown
to allow for this. However, this only allows something like_bold *within* italic_
and not*bold _overlapping* italic_
. The announcement is not every clear, if that is also allowed …Did I miss anything?