Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 4.4 changes #1464

Merged
merged 22 commits into from Sep 6, 2019

Conversation

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Aug 5, 2019

Attempt to incorporate API 4.4 changes.

Stuff I'm not sure I handled it correctly:

  • de_json methods (Chat and ChatPermission)
  • Deprecation warning for all_members_are_administrators in Chat
  • new parameter sytax for restrict_chat_members in Bot
  • Does something need to be changed for the new webhooks?
  • Preparation for API 4.5, which brings nested MessageEntities: I adjusted Message._parse_html and Message._parse_markdown to allow for this. However, this only allows something like _bold *within* italic_ and not *bold _overlapping* italic_. The announcement is not every clear, if that is also allowed …

Did I miss anything?

Hinrich Mahler
@Nukesor

This comment has been minimized.

Copy link

Nukesor commented Aug 5, 2019

FYI: The 4.2 and 4.3 Changes are still not merged: #1418

@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review Aug 8, 2019
@Nukesor

This comment has been minimized.

Copy link

Nukesor commented Aug 9, 2019

Pls remove the WIP: from the title , if it's really ready for review :D.
Otherwise this might be overlooked.

@Bibo-Joshi Bibo-Joshi changed the title WIP: Api 4.4 changes API 4.4 changes Aug 9, 2019
@Bibo-Joshi

This comment has been minimized.

Copy link
Member Author

Bibo-Joshi commented Aug 9, 2019

Ah, overlooked that one. Thanks for the heads up :)

Bibo-Joshi and others added 3 commits Aug 23, 2019
 Conflicts:
	telegram/chatmember.py
	tests/test_bot.py
@tsnoam tsnoam force-pushed the Bibo-Joshi:api-4.4 branch from 3b8763a to 0087ad3 Aug 28, 2019
@Poolitzer Poolitzer mentioned this pull request Aug 29, 2019
Copy link
Member

Eldinnie left a comment

A few notes

telegram/bot.py Show resolved Hide resolved
telegram/chat.py Outdated Show resolved Hide resolved
telegram/chatpermissions.py Show resolved Hide resolved
telegram/message.py Outdated Show resolved Hide resolved
tests/test_official.py Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi added the API label Sep 6, 2019
@tsnoam tsnoam requested a review from Eldinnie Sep 6, 2019
@tsnoam
tsnoam approved these changes Sep 6, 2019
@tsnoam tsnoam merged commit 965ad17 into python-telegram-bot:master Sep 6, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 92.77%)
Details
codecov/project 92.87% (+0.09%) compared to 425912d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.