Add dispatcher argument to Updater #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the open problems marked by CI? |
|
Fixed Flake8 and Codacy (by adding a property to |
|
pre-commit still gives a flake8 error |
|
I'm also confused to why codecov isn;t running on this. |
Eldinnie
approved these changes
Oct 15, 2019
|
We can ignore the codecov problem here. Ready to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to pass a pre-initialized
Dispatcherinstance toUpdater, closing #1407.If the new
dispatcherargument is used, attributes likebotandjob_queueare fetched from thedispatcherrather than initializing them.In the docstring tried to make clear that proper initialization of the
dispatcheris up to the user, i.e. it is not checked ifdispatcher.job_queue is not None.Also added tests for creation with
dispatcher. I hope those are enough …