Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc fixes #1499

Merged
merged 21 commits into from
Sep 13, 2019
Merged

Doc fixes #1499

merged 21 commits into from
Sep 13, 2019

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Sep 1, 2019 •
edited
Loading

jsmnbom and others added 18 commits February 17, 2019 16:39
@jsmnbom
Clarify InlineKeyboardButton callback-data docstring
3d0b8bb 
Fixes #1267
@jsmnbom
Improve documentation slightly
6a679a7 
- Prettier changelog
- Link to examples on frontpage
- Link to wiki on frontpage
- Put telegram.ext in own sidebar thingy
@jsmnbom
Improve ext.Filters documentation
f241760 
Superseeds #1089

- Remove `:obj:Filter` as it's pretty obvious that it's a filter since it's in this module. It also made the html output about 1/3 times longer to scroll through.
- Add an __all__ to reorder so Filter is at the top instead of BaseFilter
- Add a proper docstring for document that documents the attributes (this is the #1089 part)
- Also fix a couple of grammar errors.
@jsmnbom
Fix indentation in telegram.rst
3eb31c9
@jsmnbom
Add git describe --long --tags to the python -m telegram output
8b253d6
@jsmnbom
Use admonition for examples to make them *pop* better
4bf34b7
@jsmnbom
Remove automodule telegram
883ece1 
Sphinx was whining a lot and it doesn't actually seem to be needed in any way?
@Eldinnie @jsmnbom
Fix Filters.document docstring per CR
620ee5b 
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
@Eldinnie @jsmnbom
Fix spelling error in docs index
2f1fba2 
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
@jsmnbom
Setting needs_sphinx to 1.7.9
895c904 
so we don't have more issues with incongruent versions
@Eldinnie
Fixed last warnings
f14fdcc
@Eldinnie
Make pre-commit happy
1d0f2df
Fix linebreak in parse_*_entity. Closes #1207
4620557
@Bibo-Joshi
Merge branch 'master' into doc-fixes
cdc5f02
@Bibo-Joshi
Add missing LoginUrl to docs
4927623
added LoginUrl to the docs, improved its text
5714889
@Bibo-Joshi
Put telegram.utils in it's own sidebar thingy
48f8f85
@Bibo-Joshi
Minor formatting change
bd48110
jsmnbom
jsmnbom requested changes Sep 11, 2019
View reviewed changes
Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks very good. I left a couple comments of things that should be changed, or that I'm unsure of.

docs/source/telegram.loginurl.rst Outdated Show resolved Hide resolved
docs/source/telegram.rst Show resolved Hide resolved
telegram/ext/conversationhandler.py Show resolved Hide resolved
@tsnoam tsnoam merged commit f13aeaa into master Sep 13, 2019
@tsnoam tsnoam deleted the doc-fixes branch September 13, 2019 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsmnbom jsmnbom jsmnbom requested changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bibo-Joshi @jsmnbom @tsnoam @Eldinnie