Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes #1499

Merged
merged 21 commits into from Sep 13, 2019

Conversation

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Sep 1, 2019

  • LoginUrl added
  • telegram.utils got it's own sidebar thingy
  • Fix for #1207
  • Remove deprecated timed_out_behavior from ConversationHandler docstring
jsmnbom and others added 18 commits Feb 17, 2019
- Prettier changelog
- Link to examples on frontpage
- Link to wiki on frontpage
- Put telegram.ext in own sidebar thingy
Superseeds #1089

- Remove `:obj:Filter` as it's pretty obvious that it's a filter since it's in this module. It also made the html output about 1/3 times longer to scroll through.
- Add an __all__ to reorder so Filter is at the top instead of BaseFilter
- Add a proper docstring for document that documents the attributes (this is the #1089 part)
- Also fix a couple of grammar errors.
Sphinx was whining a lot and it doesn't actually seem to be needed in any way?
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
Co-Authored-By: jsmnbom <jsmnbom@gmail.com>
so we don't have more issues with incongruent versions
Bibo-Joshi added 2 commits Sep 8, 2019
Copy link
Member

jsmnbom left a comment

Mostly looks very good. I left a couple comments of things that should be changed, or that I'm unsure of.

docs/source/telegram.loginurl.rst Outdated Show resolved Hide resolved
docs/source/telegram.rst Show resolved Hide resolved
telegram/ext/conversationhandler.py Show resolved Hide resolved
@tsnoam tsnoam merged commit f13aeaa into master Sep 13, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tsnoam tsnoam deleted the doc-fixes branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.