Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all_members_are_administrators only by kwargs #1510

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Sep 7, 2019

As discussed offline, this removes all_members_are_administrators from Chat s parameters. I didn't remove it from test_chat since Telegram still returns it, so I guess we should still test it.

This comment has been minimized.

Copy link
Member

tsnoam commented Sep 7, 2019 — with Telegram GithubBot Revised

@Bibo-Joshi That's a good idea regarding the test. That way we'd get test failures when telegram will stop sending this parameter and we'll know to remove it from our code base.

@tsnoam tsnoam merged commit fba3cc9 into master Sep 7, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 92.93%)
Details
codecov/project 92.93% (+0%) compared to 965ad17
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tsnoam tsnoam deleted the remove-amaa branch Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.