Fix for Bot.to_dict returning the wrong value for first_name (#1519)

[clonex10100]

Closes #1519

[tsnoam]

@clonex10100 1. We have a very fragile logic with username/first name/last name when it comes to user details.
We should make sure it's either consistent or the difference makes sense.

2. Unitests seems to fail due to (what I think is) a change in the shell scripting behaviour of Travis. The if... then... logic should be modified to have else true (this is very common behaviour with Makefile)

[Poolitzer]

Hey @tsnoam , what do you mean?

1. The bots first name should be the bots first name. Its always given, it should be correctly returned in the to_dict function.

2. Unitest should not fail because of this change. If there is actually an issue in the file, we should move it to a separate issue and PR, but this one is fine imo

The only issue I see is that the branch isn't named properly and OP didnt add themself to the author file :)

[tsnoam]

@Poolitzer
I would expect test_get_me_and_properties() to fail after this change.
I need to understand why it didn't fail before or why it doesn't fail now.

[tsnoam]

uh. of course. we need a new test for to_dict

[Poolitzer]

@tsnoam because that is not affected by to_dict right? They are only using de_json