Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding to_dict test #1544

Merged
merged 1 commit into from Oct 12, 2019

Conversation

@Poolitzer
Copy link
Contributor

Poolitzer commented Oct 12, 2019

closes #1541

@tsnoam
tsnoam approved these changes Oct 12, 2019
Copy link
Member

tsnoam left a comment

this has the same problem like test_get_me_and_properties() though less severe.
we basically check the same object with itself. we need to use the "secret" environment variables for this test as well.
I will fix it with #1545

@tsnoam tsnoam merged commit 3545139 into python-telegram-bot:master Oct 12, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 93.04% (-0.02%) compared to d0c27e2
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing d0c27e2...8c89687
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.