Implement github actions ci #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for b64+json encoded github secret with all the vars - Add bot_name and bot_username since it's needed for a proper get_me test
- Add coverage - Install ujson - test_official only run on in single job - Pass bot info to pytest
jsmnbom
force-pushed
the
github-actions-ci
branch
from
8fd5dff
to
0a18b85
Compare
jsmnbom
force-pushed
the
github-actions-ci
branch
from
0a18b85
to
262e3c6
Compare
jsmnbom
force-pushed
the
github-actions-ci
branch
4 times, most recently
from
58b9d37
to
9d3ac3d
Compare
jsmnbom
force-pushed
the
github-actions-ci
branch
from
9d3ac3d
to
32b9b5c
Compare
jsmnbom
force-pushed
the
github-actions-ci
branch
from
1a919a2
to
e0bf4f7
Compare
|
This should be ready for review. Some notes:
|
|
Okay nvm, still some issues. Looks like 'continue-on-error' doesn't do quite what i thought, so right now the builds never actually fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be as functional as travis and appveyor but now it's all in one place.
Note: Travis and Appveyor CI will probably fail since they will use fallback tokens.
@Poolitzer did most of the initial work getting pytest to work, and i think he's working on more github actions stuff.