Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for switch_inline_query #1635

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Add tests for switch_inline_query #1635

merged 2 commits into from
Mar 30, 2020

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 23, 2019 •
edited
Loading

Closes #1601.
Turns out only switch_inline_quer(_current_chat) can reasonably be an empty string. All other optionals should be either None or a non-empty string.

@Bibo-Joshi Bibo-Joshi added this to the 12.5 milestone Nov 23, 2019
Poolitzer
Poolitzer approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper test, looks good.

@Bibo-Joshi Bibo-Joshi merged commit 61a66a3 into master Mar 30, 2020
@Bibo-Joshi Bibo-Joshi deleted the empty_string_tests branch March 30, 2020 22:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees
No one assigned
Labels
pending review tests
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

Add tests for optional parameters that should accept empty string as input
2 participants
@Bibo-Joshi @Poolitzer