-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong signature call for ConversationHandler.TIMEOUT handlers (issue #1652) #1653
Conversation
Forced push was necessary to trigger the checks to run again, because one failed for unrelated reasons. |
`Thanks for making this fix. |
@Eldinnie PTB does have tests for the So would you like to see the existing tests migrated to use context or rather have separate tests? I'd opt for the latter for backward compatibility for now. |
@tobiaswicker Switching all the tests to contexts is actually an issue, #1509 |
@Poolitzer OK, thanks! @Eldinnie does the mentioned issue satisfy your request for a test or have you had a test in mind that wouldn't be covered by migrating any of the existing tests? |
@tobiaswicker I am very sure that solving that issue will satisfy his testing needs |
@Poolitzer Note, that #1509 is currently assigned only to the v13,0 milestone, which will probably not be closed too soon. |
@Bibo-Joshi I mean, we are talking about a test for a callback here. I dont think it will break soon enough that we will have a problem with adding this test later, do you? |
@Poolitzer I guess not. Just wanted to mention it ;) |
@Bibo-Joshi Fair enough |
@tobiaswicker IMO the new PR should be paired with a test. One that would fail without this fix, and will pass with this fix. |
@tobiaswicker thankyou for your contribution |
Fix for issue #1652