Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in helper.py enocde_conversations_to_json #1661

Merged
merged 1 commit into from Jan 26, 2020
Merged

Fixed typo in helper.py enocde_conversations_to_json #1661

merged 1 commit into from Jan 26, 2020

Conversation

rizlas
Copy link
Contributor

@rizlas rizlas commented Dec 16, 2019 •
edited by Bibo-Joshi

Fixed typo in helper.py enocde_conversations_to_json function.
Closes #1660

Files modified:

	modified:   AUTHORS.rst
	modified:   telegram/ext/dictpersistence.py
	modified:   telegram/utils/helpers.py
	modified:   tests/test_persistence.py

@Bibo-Joshi Bibo-Joshi added this to the 12.4 milestone Dec 16, 2019
@Bibo-Joshi
Copy link
Member

Thanks! I took the liberty to change "Refer to" to "Closes" so that #1660 will be automatically closed, when this is merged ;)

@rizlas
Copy link
Contributor Author

rizlas commented Dec 16, 2019

Thanks to you! You did an amazing work with this library!

tsnoam
tsnoam approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a braking change to users who might have used it.
however, this is an internal function and no one should have used it.
merging now.

@tsnoam tsnoam merged commit e3c8466 into python-telegram-bot:master Jan 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam approved these changes

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees
No one assigned
Labels
bug 🐛 pending merge
Projects
None yet
Milestone
12.4
Development

Successfully merging this pull request may close these issues.

[BUG] Typo in def of enocde_conversations_to_json
3 participants
@rizlas @Bibo-Joshi @tsnoam