Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poll messages support to filters #1673

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

blueset
Copy link
Contributor

@blueset blueset commented Dec 25, 2019

This PR fixes #1672

It adds poll message support to filters (telegram.ext.filters.Filters.poll). Both filter code and tests are updated accordingly.

@Bibo-Joshi Bibo-Joshi added this to the 12.4 milestone Dec 29, 2019
@Bibo-Joshi
Copy link
Member

We added both poll and poll_answer filters in the the API 4.6 PR #1723, so I'm going to close this one. Still, thanks for taking the time and doing this PR :)

@Bibo-Joshi Bibo-Joshi closed this Jan 26, 2020
@Poolitzer
Copy link
Member

Poolitzer commented Jan 26, 2020

Actually, we don't, we add the update type, not the message attribute; we can just merge this on its own.

@Poolitzer Poolitzer reopened this Jan 26, 2020
@tsnoam tsnoam merged commit d9d65cc into python-telegram-bot:master Jan 26, 2020
@Bibo-Joshi Bibo-Joshi mentioned this pull request Feb 10, 2020
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add telegram.ext.filters.Filters.poll for native poll messages
4 participants