Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConversationHandler attributes immutable #1756

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Make ConversationHandler attributes immutable #1756

merged 2 commits into from
Mar 30, 2020

Conversation

Bibo-Joshi
Copy link
Member

This should close #1029

@Bibo-Joshi Bibo-Joshi added this to the 12.5 milestone Feb 6, 2020
@Bibo-Joshi
Copy link
Member Author

CI Fail unrelated (test_webhook_invalid_posts)

Poolitzer
Poolitzer approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper changes, proper testing, nothing to complain. LGTM

@Bibo-Joshi Bibo-Joshi merged commit 982f670 into master Mar 30, 2020
@Bibo-Joshi Bibo-Joshi deleted the fix-1029 branch March 30, 2020 15:37
@Bibo-Joshi Bibo-Joshi mentioned this pull request May 4, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

ConversationHandler is not thread safe
2 participants
@Bibo-Joshi @Poolitzer