Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove builtin names where possible #1792

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Remove builtin names where possible #1792

merged 1 commit into from
Feb 23, 2020

Conversation

Bibo-Joshi
Copy link
Member

Closes #1766

all is still used in filters.py for Filters.all.
id and type are used multiple times in the files classes, but that's API …
However, in the tests I changed all id and type variables to id_ and type_.

@Bibo-Joshi Bibo-Joshi added this to the 12.5 milestone Feb 23, 2020
@Bibo-Joshi
Copy link
Member Author

CI: test_set_game_score is unrelated. codecov: 🤷‍♂️

@tsnoam tsnoam merged commit 1dc67dc into master Feb 23, 2020
@tsnoam tsnoam deleted the fix-1766 branch February 23, 2020 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Awaiting requested review from Poolitzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

Don't use builtin function names as variables
2 participants
@Bibo-Joshi @tsnoam