API 4.7 #1858
Merged
API 4.7 #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnoam
requested changes
Mar 30, 2020
4 tasks
tsnoam
requested changes
Apr 1, 2020
tsnoam
reviewed
Apr 7, 2020
tsnoam
requested changes
Apr 7, 2020
About the not-tested lines:
|
tsnoam
approved these changes
Apr 8, 2020
Poolitzer
requested changes
Apr 9, 2020
|
|
||
| dice = _Dice() | ||
| """Dice Messages. If an integer or a list of integers is passed, it filters messages to only | ||
| allow those whose dice value is appearing in the given list. |
There was a problem hiding this comment.
Suggested change
| allow those whose dice value is appearing in the given list. | |
| allow those with dice where the value is appearing in the given list. |
There was a problem hiding this comment.
While this is slightly more accurate, the sentence feels kinda weird to me. And it should be clear from the context, that only dice messages are allowed. I'll not change for now. If this is important to you, you can PR for it ;)
|
CI fails unrelated. merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1856
Pure API updates:
DiceBot.send_diceMessage.diceMessage.reply_diceBotCommandBot.get_my_commandsBot.set_my_commandsBot.commandspropertytgs_stickertoBot.create_new_sticker_settgs_stickertoBot.add_sticker_to_setStickerSet.thumbBot.set_sticker_set_thumbBot.create_new_sticker_setandBot.add_sticker_to_setto release notesNew functionality:
Filters.diceto filter messages containing a diceFilters.dice(1)andFilters.dice([1, 5])to filters for dices with specific valuesFilters.textandMessage.effective_message?Problems I encountered:
Bot.create_new_sticker_setwas not tested before, I guess because we can't delete packs via the API. So I don't test with the new parameter, either.Bot.upload_sticker_fileseems to accept TGS files aspng_sticker. I'm jusing it ittest_bot_methods_1_tgsright now. Also pinged @botsupport about it.file_idis not validmask_positionforadd_sticker_to_setwas untested. If I see correctly, request posts differently when posting files, which is the case for stickers, and thus themask_positionhas to beto_json-ed manually. Added that and the corresponding test.