Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] InlineQueryResultAudio doc fix #1874

Merged
merged 6 commits into from
Apr 7, 2020
Merged

[Documentation] InlineQueryResultAudio doc fix #1874

merged 6 commits into from
Apr 7, 2020

Conversation

harshil21
Copy link
Member

No description provided.

@harshil21 harshil21 changed the title InlineQueryResultAudio doc fix [Documentation] InlineQueryResultAudio doc fix Apr 6, 2020
Bibo-Joshi
Bibo-Joshi requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the catch. Please have a look at my comments below. Would you maybe like to extend the PR to the other classes as well?

telegram/inline/inlinequeryresultaudio.py Outdated Show resolved Hide resolved
telegram/inline/inlinequeryresultaudio.py Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi added this to the 12.6 milestone Apr 7, 2020
@harshil21
More doc fixes
4487923 
All docs were obtained from official Bot API docs.
@harshil21
Shortened line length
5282025 
Did this so it passes codacy check
Bibo-Joshi
Bibo-Joshi reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were thorugh, thank you so much! Unfortunately, I was mistaken about the id - I had been thinking of them as integers, like update ids. I'll revert that for you.

@Bibo-Joshi Bibo-Joshi merged commit beb8ba3 into python-telegram-bot:master Apr 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi requested changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harshil21 @Bibo-Joshi