Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favor concrete types over "Iterable" #1882

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Favor concrete types over "Iterable" #1882

merged 3 commits into from
Apr 8, 2020

Conversation

Bibo-Joshi
Copy link
Member

Closes #1881

@Bibo-Joshi Bibo-Joshi added this to the 12.6 milestone Apr 8, 2020
tsnoam
tsnoam requested changes Apr 8, 2020
View reviewed changes
Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hinting should be list|tuple

The text can stay as you changed it (only list)

telegram/ext/updater.py Outdated Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit 3101ea8 into master Apr 8, 2020
@Bibo-Joshi Bibo-Joshi deleted the fix-1881 branch April 8, 2020 20:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam approved these changes

Assignees
No one assigned
Labels
bug 🐛 documentation
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

Use concrete types instead of iterable
2 participants
@Bibo-Joshi @tsnoam