Remove NullHandlers to unsuppress lastResort loging handler #1913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement to call
logging.basicConfig()
to see errors raised in handlers.Users that already configure logging are unaffected by this change. Users that rely on python default logging configuration will now see warning+ level logs from PTB in stderr.
Suppressing default logging handler is not a good way control whether or not PTB logging is enabled, since users that actually do want to disable PTB logs might need to use basicConfig to configure something else. For this reason I removed all NullHandlers and not just the ones in dispatcher and updater.