Api 4.8

[Bibo-Joshi]

Pure API changes

• Bot.send_poll: explanation, explanation_parse_mode,
• Poll.{explanation, explanation_entities, open_period, close_date}
• Bot.send_dice: emoji (for whatever reason, sending a 'darts' is considered a die now …
• Dice.emoji

Convenience stuff

• Poll.parse_explanation_entity/ies
• Filters.dice.dice and Filters.dice.darts for filtering only the corresponding emojis. Allow the Filters.dice.*([1, 2]) syntax for both

Todo

• Release notification should maybe include a statemant, that Dice a second positional argument.
• Telegram seems to have changed something with the photos. Getting telegram.error.BadRequest: Type of file mismatch. Need to investigate

[Poolitzer]

@Bibo-Joshi Last time I faced this error in the support groups I suggested checking the dimensions of it. Maybe try uploading said photo as document, if that works, that might be it?

[Bibo-Joshi]

@Poolitzer Problem seems to be sending a photo via

with open('tests/data/thumb.jpg', 'rb') as f:
    bot.send_photo(chat_id, f)

Problem persists, if I swat tests/data/telegram.jpg with telegram.png or thumb.jpg. However, I have no problems sending the to myself with a personal bot(token). Could that be a type of flood control? We have been getting some flooding errors in the tests recently … @tsnoam maybe we can add new/replace the existing tests bots?

[Poolitzer]

great PR, slight improvement

[Poolitzer]

One thing: What about adding the emojis from Dice as constants? We normally do that. Right now we only have a list.

[Bibo-Joshi]

One thing: What about adding the emojis from Dice as constants? We normally do that. Right now we only have a list.

Added that. Still kept the ALL_EMOJI list, though

[Poolitzer]

@Bibo-Joshi Sure, didnt complain about that ;P

[Bibo-Joshi]

CI Fail: test_max_caption_length gives an Internal server error for some reason. seems unrelated.
Coverage: can't test utf-16 encoding, that's basically it. Still, codecov is satisfied.

[tsnoam]

In general looks good. A small comment on docstring.

However, I did not understand the following action item in the PR description:

Release notification should maybe include a statemant, that Dice a second positional argument.