Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 4.9 update #1980

Merged
merged 16 commits into from
Jun 22, 2020
Merged

API 4.9 update #1980

merged 16 commits into from
Jun 22, 2020

Conversation

Poolitzer
Copy link
Member

@Poolitzer Poolitzer commented Jun 5, 2020

Basketball was added by @code1mountain, rest done by me.
Open questions:

  • How to test for via_bot attribute of a Message
  • Do we want to offer the mime types of the InlineQueryResults thumb urls as constants? If yes, where?

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Jun 5, 2020

Thanks for the quick PR! Will have a closer look later today/on the weekend

  • How to test for via_bot attribute of a Message

We're currently only testing answer_inline_query by mocking. But as setting the attribute is not our thing to do, but TGs, personally I'd say test manually and that's it.

  • Do we want to offer the mime types of the InlineQueryResults thumb urls as constants? If yes, where?

Can you test, if TG servers infere that automatically? If yes: I don't really see a need for someone setting that manually and hence, for adding the corresponding constants

Copy link
Member Author

@Bibo-Joshi The docs say telegrams server automatically assume JPEG. I can test it if you want

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, had a closer look.

  • Docs need checking, as mentioned offline
  • test_message should be updated regarding to/from_dict/json
  • Depending on your tests, constants for thumb_mime_type would be good imo

@Bibo-Joshi Bibo-Joshi added the API label Jun 5, 2020
@Bibo-Joshi Bibo-Joshi merged commit 927502e into master Jun 22, 2020
@Bibo-Joshi Bibo-Joshi deleted the 4.9_update branch June 22, 2020 18:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants