-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 4.9 update #1980
API 4.9 update #1980
Conversation
Added Basketball Dice Variation
Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
Add Basketball Dice
Thanks for the quick PR! Will have a closer look later today/on the weekend
We're currently only testing
Can you test, if TG servers infere that automatically? If yes: I don't really see a need for someone setting that manually and hence, for adding the corresponding constants |
@Bibo-Joshi The docs say telegrams server automatically assume JPEG. I can test it if you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, had a closer look.
- Docs need checking, as mentioned offline
test_message
should be updated regardingto/from_dict/json
- Depending on your tests, constants for
thumb_mime_type
would be good imo
Basketball was added by @code1mountain, rest done by me.
Open questions: