Remove error handlers from examples #1983
Conversation
Most examples use the same error handler, that error handler logs update.to_dict but doesn't log error traceback. Hiding error traceback is quite bad, removing the error handler entirely causes PTB to use default error logging which does include error traceback.
|
@n5y Kind of related to our refactoring to drop the need to import and call logging. I wanted to get (up) to (date on) that, soonTM |
|
Hi. Thanks for the PR. After short internal discussion we'd like to add a dedicated error handler example to the examples section in the same move. Would you care to add one? You can base it on the snippet in the wiki. |
|
I don't think lack of custom error handler example justifies keeping traceback-hiding error handlers in the examples any longer. Especially if there is a wiki entry about custom error handlers. I also don't think the wiki snippet can be used as is. It's rather complex, but lacks some required safeguards and can hide original exception with a new one. It re-rises exception at the end which I don't think works too well with how PTB handles this. It uses f-string which are not supported by python 3.5. Perhaps the snippet can just continue to live in the wiki where it can keep f-strings and is easier to modify. It's also easier to show multiple handler variants on the wiki. Or perhaps we can make another feature request issue specifically for an error handler example. |
|
Yeah the snippet isnt perfect, agreed. Nonetheless, a simple error handler example isnt too hard to do, if you dont want to, I will happily throw one together. Im not sure I get It re-rises exception at the end which I dont think works too well with how PTB handles this. This re raising works perfectly for me. |
|
okay I added a simple error handler imo, is that ok? |
Including: - Change the telegram message to include usual python error message. - HTML-escape the strings used to build the telegram message. - Capitalize comments and add more empty lines to hopefully unify the style with other examples, at least a bit. - Reorder imports.
This reverts commit c4efea6
Otherwise the example will require two edits 40 lines apart to run.
The example requires you to set developer chat id, this change will make things easier for users that don't know how to see their chat id.
|
I also added chat id in start command response to make it easier for people who don't know how to see their chat id. |
|
Should I squash this branch into a single "Remove error handlers from examples and add a dedicated error handler example" commit? And reabase it onto current master. |
No need. I'll squash on merge. Edit: I forgot about the Readme in the examples directory. Please list the new example there. |
|
There are a few other examples missing from the readme, but I think it should be fixed in a separate PR, rather than this one. |
Thanks for pointing that out. Updated right now, giving you a MC ;P. But @Poolitzer wants to review anyway. |
This should have been done a long time ago. A new example for a custom error handler can be added later.
Closes #1921