Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override builtin method help() #1997

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

OctoNezd
Copy link
Contributor

The echobot2 example overrides builtin method help(). This PR renames the help(update, context) function to help_command(update, context).

Perhaps change start to start_command too?

@Bibo-Joshi
Copy link
Member

Personally, I don't see a need to change start, as that's not builtin. But would you mind checking the other examples, too?

@OctoNezd
Copy link
Contributor Author

The only other examples that used help() are inllinebot and inlinekeyboard. Both updated now.

@Bibo-Joshi Bibo-Joshi merged commit 0af5cc2 into python-telegram-bot:master Jun 16, 2020
@Bibo-Joshi
Copy link
Member

Thanks for you contribution!

@OctoNezd OctoNezd deleted the patch-1 branch June 16, 2020 15:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants