Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: via_bot filter #2009

Merged
merged 4 commits into from
Jul 14, 2020
Merged

feat: via_bot filter #2009

merged 4 commits into from
Jul 14, 2020

Conversation

Poolitzer
Copy link
Member

also fixing a small mistake in the empty parameter of the user filter (and the test for it) and improved docs slightly

@Poolitzer
feat: via_bot filter
d896634 
also fixing a small mistake in the empty parameter of the user filter and improve docs slightly
@Poolitzer
fix: forgot to set via_bot to None
779bbac
Bibo-Joshi
Bibo-Joshi requested changes Jun 29, 2020
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)
Left some comments. I didn't look at the tests, but I trust that you basically copied them from Filters.user, so that should be fine (except for the test modifications for the Filters.user.filter() change of course :P)

telegram/ext/filters.py Outdated Show resolved Hide resolved
telegram/ext/filters.py Outdated Show resolved Hide resolved
telegram/ext/filters.py Outdated Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
@Bibo-Joshi
Copy link
Member

Thanks for the update @Poolitzer!
I did some cosmetic changes. Didn't look at code and tests too thoroughly, as they're mostly copy-paste. Test succeed, merging :)

@Bibo-Joshi Bibo-Joshi merged commit 0189442 into master Jul 14, 2020
@Bibo-Joshi Bibo-Joshi deleted the via_bot_filter branch July 14, 2020 19:51
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jul 15, 2020
Closed
Bibo-Joshi added a commit that referenced this pull request Jul 16, 2020
@Bibo-Joshi @Poolitzer
Fix typo in CHANGES.rst (#2024)
5f26172 
* Fix PicklePersistence.flush() with only bot_data (#2017)

* Update pylint in pre-commit to fix CI (#2018)

* Add Filters.via_bot (#2009)

* feat: via_bot filter

also fixing a small mistake in the empty parameter of the user filter and improve docs slightly

* fix: forgot to set via_bot to None

* fix: redoing subclassing to copy paste solution

* Cosmetic changes

Co-authored-by: Hinrich Mahler <hinrich.mahler@freenet.de>

* Update CHANGES.rst

Fixed Typo

Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Poolitzer @Bibo-Joshi