-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor @run_async #2051
Refactor @run_async #2051
Conversation
# Conflicts: # telegram/ext/dispatcher.py # telegram/ext/messagehandler.py # telegram/ext/regexhandler.py
I made two additional changes to
|
Could this |
@GauthamramRavichandran Please have a look at this comment :) |
…am-bot/python-telegram-bot into refactor-run-async
This reverts commit e4b5e2e
As discussed, I restructured a bit. Let me try to summarize:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
update
anderror_handler
toDP.run_async()
to allow proper error handlingDP.add_handler
/DP.add_error_handler
One problem: In the new setting it's currently not possible to make the handlers of a
ConversationHandler
be run asynchronously. Possible solutions:DP.add_handler(CH, run_asyn=True)
make all handlers of the Conversation asyncrun_async
flag as parameter forHandler
instead of as parameter forDP.add_handler
Wanted to have that clarified before going for the tests, so WIP.
When ready, closes #682 and superseeds/closes #785