Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Webhook not working on windows with py38+ #2067

Merged
merged 6 commits into from Aug 25, 2020
Merged

Fix Webhook not working on windows with py38+ #2067

merged 6 commits into from Aug 25, 2020

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Aug 25, 2020 •
edited

As discussed with @tsnoam. Thanks @n5y for getting started with this.

I moved the webhook_ready.set() to WebhookServer.serve_forever() as setting it in Updater._start_webhook didn't seem to suffice for the tests not to need sleep(0.1)

I hope the description of force_event_loop is descriptive enough

Closes #1977

@Bibo-Joshi Bibo-Joshi added this to the 13.0 milestone Aug 25, 2020
tsnoam
tsnoam requested changes Aug 25, 2020
View reviewed changes
telegram/utils/webhookhandler.py Outdated Show resolved Hide resolved
telegram/utils/webhookhandler.py Outdated Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit bb34c79 into master Aug 25, 2020
@Bibo-Joshi Bibo-Joshi deleted the tornado-py38-win branch August 25, 2020 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam requested changes

Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

[BUG] Webhook NotImplementedError on windows with python 3.8
3 participants
@Bibo-Joshi @tsnoam @n5y